wifi: mac80211: mlme: clarify WMM messages
authorJohannes Berg <johannes.berg@intel.com>
Thu, 8 Jun 2023 13:36:00 +0000 (16:36 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 14 Jun 2023 10:20:08 +0000 (12:20 +0200)
These messages apply to a single link only, use link_info()
to indicate that.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230608163202.21a6bece4313.I08118e5e851fae2f9e43f8a58d3b6217709bf578@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/mlme.c

index 2701338..f137929 100644 (file)
@@ -2639,9 +2639,9 @@ ieee80211_sta_wmm_params(struct ieee80211_local *local,
                params[ac].aifs = pos[0] & 0x0f;
 
                if (params[ac].aifs < 2) {
-                       sdata_info(sdata,
-                                  "AP has invalid WMM params (AIFSN=%d for ACI %d), will use 2\n",
-                                  params[ac].aifs, aci);
+                       link_info(link,
+                                 "AP has invalid WMM params (AIFSN=%d for ACI %d), will use 2\n",
+                                 params[ac].aifs, aci);
                        params[ac].aifs = 2;
                }
                params[ac].cw_max = ecw2cw((pos[1] & 0xf0) >> 4);
@@ -2652,9 +2652,9 @@ ieee80211_sta_wmm_params(struct ieee80211_local *local,
 
                if (params[ac].cw_min == 0 ||
                    params[ac].cw_min > params[ac].cw_max) {
-                       sdata_info(sdata,
-                                  "AP has invalid WMM params (CWmin/max=%d/%d for ACI %d), using defaults\n",
-                                  params[ac].cw_min, params[ac].cw_max, aci);
+                       link_info(link,
+                                 "AP has invalid WMM params (CWmin/max=%d/%d for ACI %d), using defaults\n",
+                                 params[ac].cw_min, params[ac].cw_max, aci);
                        return false;
                }
                ieee80211_regulatory_limit_wmm_params(sdata, &params[ac], ac);
@@ -2663,9 +2663,9 @@ ieee80211_sta_wmm_params(struct ieee80211_local *local,
        /* WMM specification requires all 4 ACIs. */
        for (ac = 0; ac < IEEE80211_NUM_ACS; ac++) {
                if (params[ac].cw_min == 0) {
-                       sdata_info(sdata,
-                                  "AP has invalid WMM params (missing AC %d), using defaults\n",
-                                  ac);
+                       link_info(link,
+                                 "AP has invalid WMM params (missing AC %d), using defaults\n",
+                                 ac);
                        return false;
                }
        }