pepper: fix coverity issues

Change-Id: I855de76d90e89825a3176f1a2e45257fb146f450

diff --git a/src/lib/drm/drm-connector.c b/src/lib/drm/drm-connector.c
index 0b7591f..00fc511 100644 (file)
--- a/src/lib/drm/drm-connector.c
+++ b/src/lib/drm/drm-connector.c
@@ -60,17 +60,6 @@ get_connector_name(char *str, drmModeConnector *conn)
        snprintf(str, 32, "%s%d", type_name, conn->connector_type_id);
 }
 
-static inline void
-add_connector(pepper_drm_t *drm, drmModeConnector *connector)
-{
-       drm_connector_t *conn;
-
-       conn = calloc(1, sizeof(drm_connector_t));
-       PEPPER_CHECK(conn, return, "calloc() failed.\n");
-
-       conn->connector = connector;
-}
-
 void
 drm_init_connectors(pepper_drm_t *drm)
 {

diff --git a/src/lib/pepper/keyboard.c b/src/lib/pepper/keyboard.c
index e5caabc..759a006 100644 (file)
--- a/src/lib/pepper/keyboard.c
+++ b/src/lib/pepper/keyboard.c
@@ -221,6 +221,8 @@ pepper_keyboard_bind_resource(struct wl_client *client,
        if ((keyboard->keymap_format == WL_KEYBOARD_KEYMAP_FORMAT_NO_KEYMAP)
                || (keyboard->keymap_fd < 0) || (keyboard->keymap_len == 0)) {
                int fd = open("/dev/null", O_RDONLY);
+               if (fd < 0)
+                       return;
                wl_keyboard_send_keymap(res, WL_KEYBOARD_KEYMAP_FORMAT_NO_KEYMAP,
                                                                fd, 0);
                close(fd);

diff --git a/src/lib/render/gl-renderer.c b/src/lib/render/gl-renderer.c
index 96dd3de..17fdc91 100644 (file)
--- a/src/lib/render/gl-renderer.c
+++ b/src/lib/render/gl-renderer.c
@@ -1861,6 +1861,9 @@ error:
        if (surface != EGL_NO_SURFACE)
                eglDestroySurface(gr->display, surface);
 
+       if (configs)
+               free(configs);
+
        free(target);
        return NULL;
 }