omxbufferpool: don't use CAT_PERFORMANCE if pool will copy

This was the single place where this category was used in gst-omx so
most users, including me, are generally not turning it and were missing this
important information from logs.

The copying code uses gst_video_frame_copy() which is already logging
with CAT_PERFORMANCE so we can still have this information when using
only this debug category.

diff --git a/omx/gstomxbufferpool.c b/omx/gstomxbufferpool.c
index 9700cd6..c662c42 100644 (file)
--- a/omx/gstomxbufferpool.c
+++ b/omx/gstomxbufferpool.c
@@ -30,7 +30,6 @@
 
 GST_DEBUG_CATEGORY_STATIC (gst_omx_buffer_pool_debug_category);
 #define GST_CAT_DEFAULT gst_omx_buffer_pool_debug_category
-GST_DEBUG_CATEGORY_STATIC (CAT_PERFORMANCE);
 
 typedef struct _GstOMXMemory GstOMXMemory;
 typedef struct _GstOMXMemoryAllocator GstOMXMemoryAllocator;
@@ -520,7 +519,7 @@ gst_omx_buffer_pool_alloc_buffer (GstBufferPool * bpool,
 
       for (i = 0; i < GST_VIDEO_INFO_N_PLANES (&pool->video_info); i++) {
         if (info.stride[i] != stride[i] || info.offset[i] != offset[i]) {
-          GST_CAT_DEBUG_OBJECT (CAT_PERFORMANCE, pool,
+          GST_DEBUG_OBJECT (pool,
               "Need to copy output frames because of stride/offset mismatch: plane %d stride %d (expected: %d) offset %"
               G_GSIZE_FORMAT " (expected: %" G_GSIZE_FORMAT
               ") nStride: %d nSliceHeight: %d ", i, stride[i], info.stride[i],
@@ -720,8 +719,6 @@ gst_omx_buffer_pool_class_init (GstOMXBufferPoolClass * klass)
   gstbufferpool_class->acquire_buffer = gst_omx_buffer_pool_acquire_buffer;
   gstbufferpool_class->release_buffer = gst_omx_buffer_pool_release_buffer;
 
-  GST_DEBUG_CATEGORY_GET (CAT_PERFORMANCE, "GST_PERFORMANCE");
-
   signals[SIG_ALLOCATE] = g_signal_new ("allocate",
       G_TYPE_FROM_CLASS (gobject_class), G_SIGNAL_RUN_LAST, 0, NULL, NULL, NULL,
       G_TYPE_BOOLEAN, 0);