interlace: Don't change field-pattern on PAUSED or PLAYING state

It would otherwise change the caps the element produces and cause the
element to misbehave

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1349>

diff --git a/docs/plugins/gst_plugins_cache.json b/docs/plugins/gst_plugins_cache.json
index 41c48f7..6e78adf 100644 (file)
--- a/docs/plugins/gst_plugins_cache.json
+++ b/docs/plugins/gst_plugins_cache.json
@@ -23768,7 +23768,7 @@
                         "construct-only": false,
                         "controllable": false,
                         "default": "2:3 (2)",
-                        "mutable": "null",
+                        "mutable": "ready",
                         "readable": true,
                         "type": "GstInterlacePattern",
                         "writable": true

diff --git a/gst/interlace/gstinterlace.c b/gst/interlace/gstinterlace.c
index f84b2eb..efe4e0b 100644 (file)
--- a/gst/interlace/gstinterlace.c
+++ b/gst/interlace/gstinterlace.c
@@ -240,7 +240,8 @@ gst_interlace_class_init (GstInterlaceClass * klass)
       g_param_spec_enum ("field-pattern", "Field pattern",
           "The output field pattern", GST_INTERLACE_PATTERN,
           GST_INTERLACE_PATTERN_2_3,
-          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
+          GST_PARAM_MUTABLE_READY | G_PARAM_READWRITE |
+          G_PARAM_STATIC_STRINGS));
 
   g_object_class_install_property (object_class, PROP_PATTERN_OFFSET,
       g_param_spec_uint ("pattern-offset", "Pattern offset",