ceph: fix incorrect old_size length in ceph_mds_request_args
authorXiubo Li <xiubli@redhat.com>
Thu, 9 Jun 2022 07:21:37 +0000 (15:21 +0800)
committerIlya Dryomov <idryomov@gmail.com>
Tue, 2 Aug 2022 22:54:12 +0000 (00:54 +0200)
The 'old_size' is a __le64 type since birth, not sure why the
kclient incorrectly switched it to __le32. This change is okay
won't break anything because union will always allocate more memory
than the 'open' member needed.

Rename 'file_replication' to 'pool' as ceph did. Though this 'open'
struct may never be used in kclient in future, it's confusing when
going through the ceph code.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
include/linux/ceph/ceph_fs.h

index 40740e2..49586ff 100644 (file)
@@ -433,9 +433,9 @@ union ceph_mds_request_args {
                __le32 stripe_unit;          /* layout for newly created file */
                __le32 stripe_count;         /* ... */
                __le32 object_size;
-               __le32 file_replication;
-               __le32 mask;                 /* CEPH_CAP_* */
-               __le32 old_size;
+               __le32 pool;
+               __le32 mask;                 /* CEPH_CAP_* */
+               __le64 old_size;
        } __attribute__ ((packed)) open;
        struct {
                __le32 flags;