usb: cdns3: ep0: fix the test mode set incorrectly
authorPeter Chen <peter.chen@nxp.com>
Tue, 23 Jun 2020 03:09:16 +0000 (11:09 +0800)
committerFelipe Balbi <balbi@kernel.org>
Wed, 24 Jun 2020 06:38:41 +0000 (09:38 +0300)
The 'tmode' is ctrl->wIndex, changing it as the real test
mode value for register assignment.

Cc: <stable@vger.kernel.org>
Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
Reviewed-by: Jun Li <jun.li@nxp.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
drivers/usb/cdns3/ep0.c

index 82645a2..04e4958 100644 (file)
@@ -327,7 +327,8 @@ static int cdns3_ep0_feature_handle_device(struct cdns3_device *priv_dev,
                if (!set || (tmode & 0xff) != 0)
                        return -EINVAL;
 
-               switch (tmode >> 8) {
+               tmode >>= 8;
+               switch (tmode) {
                case TEST_J:
                case TEST_K:
                case TEST_SE0_NAK: