media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
authorThomas Zimmermann <tzimmermann@suse.de>
Sat, 15 Jul 2023 18:51:53 +0000 (20:51 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Tue, 25 Jul 2023 07:24:30 +0000 (09:24 +0200)
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by kzalloc(). So do not
set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v2:
* fix commit message (Miguel)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Andy Walls <awalls@md.metrocast.net>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/pci/ivtv/ivtvfb.c
drivers/media/test-drivers/vivid/vivid-osd.c

index 0aeb9da..23c8c09 100644 (file)
@@ -1048,7 +1048,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv)
        /* Generate valid fb_info */
 
        oi->ivtvfb_info.node = -1;
-       oi->ivtvfb_info.flags = FBINFO_FLAG_DEFAULT;
        oi->ivtvfb_info.par = itv;
        oi->ivtvfb_info.var = oi->ivtvfb_defined;
        oi->ivtvfb_info.fix = oi->ivtvfb_fix;
index ec25edc..051f180 100644 (file)
@@ -310,7 +310,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev)
        /* Generate valid fb_info */
 
        dev->fb_info.node = -1;
-       dev->fb_info.flags = FBINFO_FLAG_DEFAULT;
        dev->fb_info.par = dev;
        dev->fb_info.var = dev->fb_defined;
        dev->fb_info.fix = dev->fb_fix;