Btrfs-progs: don't output baffling message when checking a fresh fs
authorMiao Xie <miaox@cn.fujitsu.com>
Fri, 25 Oct 2013 09:30:45 +0000 (17:30 +0800)
committerChris Mason <clm@fb.com>
Fri, 31 Jan 2014 16:21:59 +0000 (08:21 -0800)
As we know,  a new fs doesn't have space cache, so we set the cache generation
of the super block to be -1ULL, it is not equal to the fs generation. But the
check program didn't consider this case, and output the following message

  cache and super generation don't match, space cache will be invalidated

directly, it would be baffling the users. So we should avoid outputing such
message. This patch fixes this problem.

Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Chris Mason <clm@fb.com>
cmds-check.c

index cdcc4ba..310126a 100644 (file)
@@ -3367,7 +3367,8 @@ static int check_space_cache(struct btrfs_root *root)
        int ret;
        int error = 0;
 
-       if (btrfs_super_generation(root->fs_info->super_copy) !=
+       if (btrfs_super_cache_generation(root->fs_info->super_copy) != -1ULL &&
+           btrfs_super_generation(root->fs_info->super_copy) !=
            btrfs_super_cache_generation(root->fs_info->super_copy)) {
                printf("cache and super generation don't match, space cache "
                       "will be invalidated\n");