[name] Return full string length from API
authorBehdad Esfahbod <behdad@behdad.org>
Wed, 17 Oct 2018 02:55:17 +0000 (19:55 -0700)
committerBehdad Esfahbod <behdad@behdad.org>
Sat, 27 Oct 2018 04:22:26 +0000 (21:22 -0700)
src/hb-ot-name.cc
src/hb-ot-name.h

index e6dbe0a..3494cb7 100644 (file)
@@ -52,7 +52,7 @@ hb_ot_name_get_names (hb_face_t                 *face,
 
 
 template <typename utf_t>
-static inline hb_bool_t
+static inline unsigned int
 hb_ot_name_get_utf (hb_face_t     *face,
                    hb_name_id_t   name_id,
                    hb_language_t  language,
@@ -71,10 +71,10 @@ hb_ot_name_get_utf (hb_face_t     *face,
   if (text_size)
     *text_size = bytes.len / 2; //TODO
   /* TODO Fallback? */
-  return true; //XXX
+  return *text_size; //XXX
 }
 
-hb_bool_t
+unsigned int
 hb_ot_name_get_utf16 (hb_face_t     *face,
                      hb_name_id_t   name_id,
                      hb_language_t  language,
index fb49480..0afcd3f 100644 (file)
@@ -50,7 +50,7 @@ typedef unsigned int hb_name_id_t;
 
 
 #if 0
-HB_EXTERN hb_bool_t
+HB_EXTERN unsigned int
 Xhb_ot_name_get_utf8 (hb_face_t     *face,
                     hb_name_id_t   name_id,
                     hb_language_t  language,
@@ -58,7 +58,7 @@ Xhb_ot_name_get_utf8 (hb_face_t     *face,
                     char          *text      /* OUT */);
 #endif
 
-HB_EXTERN hb_bool_t
+HB_EXTERN unsigned int
 hb_ot_name_get_utf16 (hb_face_t     *face,
                      hb_name_id_t   name_id,
                      hb_language_t  language,
@@ -66,7 +66,7 @@ hb_ot_name_get_utf16 (hb_face_t     *face,
                      uint16_t      *text      /* OUT */);
 
 #if 0
-HB_EXTERN hb_bool_t
+HB_EXTERN unsigned int
 Xhb_ot_name_get_utf32 (hb_face_t     *face,
                      hb_name_id_t   name_id,
                      hb_language_t  language,