mmifw-ipc: free ev variable to prevent RESOURCE_LEAK 33/264133/1
authorDuna Oh <duna.oh@samsung.com>
Fri, 10 Sep 2021 06:13:45 +0000 (15:13 +0900)
committerSung-Jin Park <sj76.park@samsung.com>
Mon, 13 Sep 2021 12:14:58 +0000 (21:14 +0900)
Change-Id: I34db34fc033feb74f1f66d0a844b4f23f0584a20

src/mmifw-ipc.c

index b92a549..a736a95 100644 (file)
@@ -573,7 +573,7 @@ static void _on_connected(rpc_port_proxy_mmifw_h h, void *user_data)
        {
                LOGE("Failed to create event callbacks !");
                //TODO: Disconnect by destroying rpc_port_proxy_mmifw_h
-               return;
+               goto err;
        }
 
        r = rpc_port_proxy_mmifw_invoke_register_cb(h, focus_cb_h, state_change_cb_h, wakeup_cb_h,
@@ -582,7 +582,7 @@ static void _on_connected(rpc_port_proxy_mmifw_h h, void *user_data)
        {
                LOGE("Failed to register event callbacks !\n");
                //TODO: Disconnect by destroying rpc_port_proxy_mmifw_h
-               return;
+               goto err;
        }
 
        _connected = 1;
@@ -590,6 +590,10 @@ static void _on_connected(rpc_port_proxy_mmifw_h h, void *user_data)
        ecore_event_add(MMI_EVENT_CONNECTION, ev, NULL, user_data);
 
        LOGI("...");
+       return;
+err:
+       if (ev)
+               free(ev);
 }
 
 static void _on_disconnected(rpc_port_proxy_mmifw_h h, void *user_data)