net: ethernet: renesas: Fix return type in rswitch_etha_wait_link_verification()
authorDan Carpenter <error27@gmail.com>
Tue, 15 Nov 2022 13:09:55 +0000 (16:09 +0300)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 17 Nov 2022 13:29:52 +0000 (14:29 +0100)
The rswitch_etha_wait_link_verification() is supposed to return zero
on success or negative error codes.  Unfortunately it is declared as a
bool so the caller treats everything as success.

Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/Y3OPo6AOL6PTvXFU@kili
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/renesas/rswitch.c

index f3d27ae..c098b27 100644 (file)
@@ -920,7 +920,7 @@ static void rswitch_etha_write_mac_address(struct rswitch_etha *etha, const u8 *
                  etha->addr + MRMAC1);
 }
 
-static bool rswitch_etha_wait_link_verification(struct rswitch_etha *etha)
+static int rswitch_etha_wait_link_verification(struct rswitch_etha *etha)
 {
        iowrite32(MLVC_PLV, etha->addr + MLVC);