projects
/
profile
/
common
/
kernel-common.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2c7a9dc
)
netfilter: ipset: fix incorret comparison in hash_netnet4_data_equal()
author
Dave Jones
<davej@redhat.com>
Thu, 14 Nov 2013 15:41:01 +0000
(10:41 -0500)
committer
Pablo Neira Ayuso
<pablo@netfilter.org>
Mon, 25 Nov 2013 21:42:18 +0000
(22:42 +0100)
Both sides of the comparison are the same, looks like a cut-and-paste error.
Spotted by Coverity.
Signed-off-by: Dave Jones <davej@fedoraproject.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/ipset/ip_set_hash_netnet.c
patch
|
blob
|
history
diff --git
a/net/netfilter/ipset/ip_set_hash_netnet.c
b/net/netfilter/ipset/ip_set_hash_netnet.c
index
2bc2dec
..
6226803
100644
(file)
--- a/
net/netfilter/ipset/ip_set_hash_netnet.c
+++ b/
net/netfilter/ipset/ip_set_hash_netnet.c
@@
-59,7
+59,7
@@
hash_netnet4_data_equal(const struct hash_netnet4_elem *ip1,
u32 *multi)
{
return ip1->ipcmp == ip2->ipcmp &&
- ip
2
->ccmp == ip2->ccmp;
+ ip
1
->ccmp == ip2->ccmp;
}
static inline int