r8169: use lower_32_bits/upper_32_bits macros
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 19 Mar 2021 08:58:36 +0000 (09:58 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Mar 2021 19:08:21 +0000 (12:08 -0700)
Use the lower_32_bits/upper_32_bits macros to simplify the code.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169_main.c

index 7aad0ba..8ea6ddc 100644 (file)
@@ -1586,12 +1586,10 @@ DECLARE_RTL_COND(rtl_counters_cond)
 
 static void rtl8169_do_counters(struct rtl8169_private *tp, u32 counter_cmd)
 {
-       dma_addr_t paddr = tp->counters_phys_addr;
-       u32 cmd;
+       u32 cmd = lower_32_bits(tp->counters_phys_addr);
 
-       RTL_W32(tp, CounterAddrHigh, (u64)paddr >> 32);
+       RTL_W32(tp, CounterAddrHigh, upper_32_bits(tp->counters_phys_addr));
        rtl_pci_commit(tp);
-       cmd = (u64)paddr & DMA_BIT_MASK(32);
        RTL_W32(tp, CounterAddrLow, cmd);
        RTL_W32(tp, CounterAddrLow, cmd | counter_cmd);