LoongArch: Use UNSPEC for fmin/fmax RTL pattern [PR105414]
authorXi Ruoyao <xry111@xry111.site>
Sat, 24 Sep 2022 12:47:22 +0000 (20:47 +0800)
committerXi Ruoyao <xry111@xry111.site>
Wed, 28 Sep 2022 09:55:01 +0000 (17:55 +0800)
I made a mistake defining fmin/fmax RTL patterns in r13-2085: I used
smin and smax in the definition mistakenly.  This causes the optimizer
to perform constant folding as if fmin/fmax was "really" smin/smax
operations even with -fsignaling-nans.  Then pr105414.c fails.

We don't have fmin/fmax RTL codes for now (PR107013) so we can only use
an UNSPEC for fmin and fmax patterns.

gcc/ChangeLog:

PR tree-optimization/105414
* config/loongarch/loongarch.md (UNSPEC_FMAX): New unspec.
(UNSPEC_FMIN): Likewise.
(fmax<mode>3): Use UNSPEC_FMAX instead of smax.
(fmin<mode>3): Use UNSPEC_FMIN instead of smin.

gcc/config/loongarch/loongarch.md

index 3787fd8..214b14b 100644 (file)
@@ -35,6 +35,8 @@
   ;; Floating point unspecs.
   UNSPEC_FRINT
   UNSPEC_FCLASS
+  UNSPEC_FMAX
+  UNSPEC_FMIN
 
   ;; Override return address for exception handling.
   UNSPEC_EH_RETURN
 
 (define_insn "fmax<mode>3"
   [(set (match_operand:ANYF 0 "register_operand" "=f")
-       (smax:ANYF (match_operand:ANYF 1 "register_operand" "f")
-                  (match_operand:ANYF 2 "register_operand" "f")))]
+       (unspec:ANYF [(use (match_operand:ANYF 1 "register_operand" "f"))
+                     (use (match_operand:ANYF 2 "register_operand" "f"))]
+                    UNSPEC_FMAX))]
   ""
   "fmax.<fmt>\t%0,%1,%2"
   [(set_attr "type" "fmove")
 
 (define_insn "fmin<mode>3"
   [(set (match_operand:ANYF 0 "register_operand" "=f")
-       (smin:ANYF (match_operand:ANYF 1 "register_operand" "f")
-                  (match_operand:ANYF 2 "register_operand" "f")))]
+       (unspec:ANYF [(use (match_operand:ANYF 1 "register_operand" "f"))
+                     (use (match_operand:ANYF 2 "register_operand" "f"))]
+                    UNSPEC_FMIN))]
   ""
   "fmin.<fmt>\t%0,%1,%2"
   [(set_attr "type" "fmove")