net: phy: mscc: ptp: fix a smatch error
authorAntoine Tenart <antoine.tenart@bootlin.com>
Thu, 25 Jun 2020 15:42:06 +0000 (17:42 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 25 Jun 2020 23:22:11 +0000 (16:22 -0700)
The following error was reported by smatch:
vsc85xx_ts_read_csr() error: uninitialized symbol 'blk_hw'.

In practice this is very unlikely, as all the block identifiers given to
this functions are handled and described in an enum. The smatch error is
fixed by doing what is already done in vsc85xx_ts_write_csr: using the
"PROCESSOR" block by default.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/mscc/mscc_ptp.c

index 17256d8..030a56c 100644 (file)
@@ -75,6 +75,7 @@ static u32 vsc85xx_ts_read_csr(struct phy_device *phydev, enum ts_blk blk,
                blk_hw = base_port ? EGRESS_ENGINE_0 : EGRESS_ENGINE_1;
                break;
        case PROCESSOR:
+       default:
                blk_hw = base_port ? PROCESSOR_0 : PROCESSOR_1;
                break;
        }