clk: xilinx: Drop if block with always false condition
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sun, 12 Mar 2023 16:14:45 +0000 (17:14 +0100)
committerStephen Boyd <sboyd@kernel.org>
Wed, 29 Mar 2023 02:23:35 +0000 (19:23 -0700)
xvcu_remove() is only called for a device after after xvcu_probe()
completed successfully. In that case dev_set_drvdata() was called for
that device with a non-NULL parameter, so platform_get_drvdata() won't
return NULL and the if condition is never true.

Drop the if, preparing a conversion to make platform driver's remove
callback return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230312161512.2715500-4-u.kleine-koenig@pengutronix.de
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/xilinx/xlnx_vcu.c

index d66b131..54b44de 100644 (file)
@@ -707,8 +707,6 @@ static int xvcu_remove(struct platform_device *pdev)
        struct xvcu_device *xvcu;
 
        xvcu = platform_get_drvdata(pdev);
-       if (!xvcu)
-               return -ENODEV;
 
        xvcu_unregister_clock_provider(xvcu);