leds: pwm: simplify if condition
authorUwe Kleine-König <uwe@kleine-koenig.org>
Fri, 24 Jan 2020 16:54:07 +0000 (17:54 +0100)
committerPavel Machek <pavel@ucw.cz>
Wed, 26 Feb 2020 20:49:39 +0000 (21:49 +0100)
.pwm_period_ns is an unsigned integer. So when led->pwm_period_ns > 0
is false, we now assign 0 to a value that is already 0, so it doesn't
hurt and we can skip checking the actual value.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Tested-by: Jeff LaBundy <jeff@labundy.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-pwm.c

index 8b6965a..b72fd89 100644 (file)
@@ -102,7 +102,7 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
        pwm_get_args(led_data->pwm, &pargs);
 
        led_data->period = pargs.period;
-       if (!led_data->period && (led->pwm_period_ns > 0))
+       if (!led_data->period)
                led_data->period = led->pwm_period_ns;
 
        ret = devm_led_classdev_register(dev, &led_data->cdev);