drm/vc4: hdmi: Remove register dumps in enable

The current code has some logic, disabled by default, to dump the register
setup in the HDMI controller.

However, since we're going to split those functions in multiple, shorter,
functions that only make sense where they are called in sequence, keeping
the register dump makes little sense.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Link: https://patchwork.freedesktop.org/patch/msgid/c8c8d388f2d32fc3536336be36d003a862487eb7.1599120059.git-series.maxime@cerno.tech
[hoegeun.kwon: Remove hdmi reg dumps, needed to troubleshoot page flip
timed out issue.]
Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
Change-Id: I8048f58783639cf790c8bb691007099943733a71

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index 61f6279..7548431 100644 (file)
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -589,7 +589,6 @@ static void vc4_hdmi_encoder_enable(struct drm_encoder *encoder)
        struct drm_display_mode *mode = &encoder->crtc->state->adjusted_mode;
        struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
        struct vc4_hdmi_encoder *vc4_encoder = to_vc4_hdmi_encoder(encoder);
-       bool debug_dump_regs = false;
        unsigned long pixel_rate, hsm_rate;
        int ret;
 
@@ -665,14 +664,6 @@ static void vc4_hdmi_encoder_enable(struct drm_encoder *encoder)
        if (vc4_hdmi->variant->phy_init)
                vc4_hdmi->variant->phy_init(vc4_hdmi, mode);
 
-       if (debug_dump_regs) {
-               struct drm_printer p = drm_info_printer(&vc4_hdmi->pdev->dev);
-
-               dev_info(&vc4_hdmi->pdev->dev, "HDMI regs before:\n");
-               drm_print_regset32(&p, &vc4_hdmi->hdmi_regset);
-               drm_print_regset32(&p, &vc4_hdmi->hd_regset);
-       }
-
        HDMI_WRITE(HDMI_VID_CTL, 0);
 
        HDMI_WRITE(HDMI_SCHEDULER_CONTROL,
@@ -698,14 +689,6 @@ static void vc4_hdmi_encoder_enable(struct drm_encoder *encoder)
 
        HDMI_WRITE(HDMI_FIFO_CTL, VC4_HDMI_FIFO_CTL_MASTER_SLAVE_N);
 
-       if (debug_dump_regs) {
-               struct drm_printer p = drm_info_printer(&vc4_hdmi->pdev->dev);
-
-               dev_info(&vc4_hdmi->pdev->dev, "HDMI regs after:\n");
-               drm_print_regset32(&p, &vc4_hdmi->hdmi_regset);
-               drm_print_regset32(&p, &vc4_hdmi->hd_regset);
-       }
-
        HDMI_WRITE(HDMI_VID_CTL,
                   HDMI_READ(HDMI_VID_CTL) |
                   VC4_HD_VID_CTL_ENABLE |