net: hns3: Fix a memory leak in an error handling path in 'hclge_handle_error_info_log()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 20 Jun 2021 09:49:40 +0000 (11:49 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 21 Jun 2021 21:30:15 +0000 (14:30 -0700)
If this 'kzalloc()' fails we must free some resources as in all the other
error handling paths of this function.

Fixes: 2e2deee7618b ("net: hns3: add the RAS compatibility adaptation solution")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Jiaran Zhang <zhangjiaran@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c

index bad9fda..ec9a7f8 100644 (file)
@@ -2330,8 +2330,10 @@ int hclge_handle_error_info_log(struct hnae3_ae_dev *ae_dev)
        buf_size = buf_len / sizeof(u32);
 
        desc_data = kzalloc(buf_len, GFP_KERNEL);
-       if (!desc_data)
-               return -ENOMEM;
+       if (!desc_data) {
+               ret = -ENOMEM;
+               goto err_desc;
+       }
 
        buf = kzalloc(buf_len, GFP_KERNEL);
        if (!buf) {