wasapi2: Allows process loopback capture on Windows 10
authorSeungha Yang <seungha@centricular.com>
Thu, 27 Apr 2023 19:28:24 +0000 (04:28 +0900)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Sun, 30 Apr 2023 15:14:53 +0000 (15:14 +0000)
As per MS documentation[1], it requires Windows 10 Build 20348
but it seems to be supported by old versions too

[1] https://learn.microsoft.com/en-us/windows/win32/api/audioclientactivationparams/
ns-audioclientactivationparams-audioclient_process_loopback_params

Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2524
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4517>

subprojects/gst-plugins-bad/sys/wasapi2/gstwasapi2util.c

index d1e2e8b..44be018 100644 (file)
@@ -526,8 +526,10 @@ gst_wasapi2_can_process_loopback (void)
        * "Windows 11", since build number of "Windows 10 version 21H2" is
        * still 19044.XXX
        */
+
+      /* But other software enables this for build number 19041 or higher... */
       if (osverinfo.dwMajorVersion > 10 ||
-          (osverinfo.dwMajorVersion == 10 && osverinfo.dwBuildNumber >= 20348))
+          (osverinfo.dwMajorVersion == 10 && osverinfo.dwBuildNumber >= 19041))
         ret = TRUE;
     }