OMAPDSS: picodlp panel: remove platform_enable/disable callbacks
authorArchit Taneja <archit@ti.com>
Tue, 4 Dec 2012 10:13:38 +0000 (15:43 +0530)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Wed, 3 Apr 2013 12:21:09 +0000 (15:21 +0300)
The picodlp panel driver now manages the gpios required to configure the
panel. This was previously done in omap_dss_device's platform_enable/disable
callbacks defined in board files using this panel.

All the board files using this panel now pass the gpio information as platform
data via the panel_generic_dpi_data struct, which is needed by the panel driver
to configure the gpios connected to the panel. Hence, the
platform_enable/disable ops can be safely removed now.

Signed-off-by: Archit Taneja <archit@ti.com>
drivers/video/omap2/displays/panel-picodlp.c

index bc8ac77..62f2db0 100644 (file)
@@ -354,12 +354,6 @@ static int picodlp_panel_power_on(struct omap_dss_device *dssdev)
        struct picodlp_data *picod = dev_get_drvdata(&dssdev->dev);
        struct picodlp_panel_data *picodlp_pdata = get_panel_data(dssdev);
 
-       if (dssdev->platform_enable) {
-               r = dssdev->platform_enable(dssdev);
-               if (r)
-                       return r;
-       }
-
        gpio_set_value(picodlp_pdata->pwrgood_gpio, 0);
        msleep(1);
        gpio_set_value(picodlp_pdata->pwrgood_gpio, 1);
@@ -398,9 +392,6 @@ static int picodlp_panel_power_on(struct omap_dss_device *dssdev)
 err:
        omapdss_dpi_display_disable(dssdev);
 err1:
-       if (dssdev->platform_disable)
-               dssdev->platform_disable(dssdev);
-
        return r;
 }
 
@@ -412,9 +403,6 @@ static void picodlp_panel_power_off(struct omap_dss_device *dssdev)
 
        gpio_set_value(picodlp_pdata->emu_done_gpio, 0);
        gpio_set_value(picodlp_pdata->pwrgood_gpio, 0);
-
-       if (dssdev->platform_disable)
-               dssdev->platform_disable(dssdev);
 }
 
 static int picodlp_panel_probe(struct omap_dss_device *dssdev)