scsi: qla2xxx: Report the firmware status code if a mailbox command fails
authorBart Van Assche <bvanassche@acm.org>
Fri, 9 Aug 2019 03:01:41 +0000 (20:01 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 13 Aug 2019 01:34:06 +0000 (21:34 -0400)
It is helpful when debugging this driver to have the firmware status code
available if a mailbox command fails. Hence report that firmware status
code.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Tested-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_mbx.c

index 133f5f6..783a846 100644 (file)
@@ -394,8 +394,12 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp)
                        goto premature_exit;
                }
 
-               if (ha->mailbox_out[0] != MBS_COMMAND_COMPLETE)
+               if (ha->mailbox_out[0] != MBS_COMMAND_COMPLETE) {
+                       ql_dbg(ql_dbg_mbx, vha, 0x11ff,
+                              "mb_out[0] = %#x <> %#x\n", ha->mailbox_out[0],
+                              MBS_COMMAND_COMPLETE);
                        rval = QLA_FUNCTION_FAILED;
+               }
 
                /* Load return mailbox registers. */
                iptr2 = mcp->mb;