container: Handle children pasting failures

diff --git a/ges/ges-container.c b/ges/ges-container.c
index a6b28ce..db402dd 100644 (file)
--- a/ges/ges-container.c
+++ b/ges/ges-container.c
@@ -348,6 +348,15 @@ _paste (GESTimelineElement * element, GESTimelineElement * ref,
     nchild =
         ges_timeline_element_paste (map->child,
         paste_position - map->start_offset);
+
+    if (!nchild) {
+      while (ncontainer->children)
+        ges_container_remove (ncontainer, ncontainer->children->data);
+
+      g_object_unref (ncontainer);
+      return NULL;
+    }
+
     ges_timeline_element_set_timeline (GES_TIMELINE_ELEMENT (ncontainer),
         GES_TIMELINE_ELEMENT_TIMELINE (ref));
     ges_container_add (ncontainer, nchild);

diff --git a/tests/check/python/test_timeline.py b/tests/check/python/test_timeline.py
index 95f9f7c..4a02c4e 100644 (file)
--- a/tests/check/python/test_timeline.py
+++ b/tests/check/python/test_timeline.py
@@ -721,6 +721,21 @@ class TestInvalidOverlaps(common.GESSimpleTimelineTest):
             ],
         ])
 
+        group = GES.Group.new()
+        group.add(clip)
+
+        copied_group = group.copy(True)
+        self.assertFalse(copied_group.paste(group.props.start))
+        self.assertTimelineTopology([
+            [
+                (GES.TestClip, 0, 10),
+            ],
+            [
+                (GES.TestClip, 0, 10),
+                (GES.TestClip, 1, 10),
+            ],
+        ])
+
     def test_move_group_with_overlaping_clips(self):
         self.track_types = [GES.TrackType.AUDIO]
         super().setUp()