tracing: Have TRACE_DEFINE_ENUM affect trace event types as well
authorSteven Rostedt (Google) <rostedt@goodmis.org>
Fri, 11 Mar 2022 04:27:38 +0000 (23:27 -0500)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Fri, 11 Mar 2022 16:49:24 +0000 (11:49 -0500)
The macro TRACE_DEFINE_ENUM is used to convert enums in the kernel to
their actual value when they are exported to user space via the trace
event format file.

Currently only the enums in the "print fmt" (TP_printk in the TRACE_EVENT
macro) have the enums converted. But the enums can be used to denote array
size:

        field:unsigned int fc_ineligible_rc[EXT4_FC_REASON_MAX]; offset:12;      size:36;        signed:0;

The EXT4_FC_REASON_MAX has no meaning to userspace but it needs to know
that information to know how to parse the array.

Have the array indexes also be parsed as well.

Link: https://lore.kernel.org/all/cover.1646922487.git.riteshh@linux.ibm.com/
Reported-by: Ritesh Harjani <riteshh@linux.ibm.com>
Tested-by: Ritesh Harjani <riteshh@linux.ibm.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events.c

index 38afd66..ae9a3b8 100644 (file)
@@ -2633,6 +2633,33 @@ static void update_event_printk(struct trace_event_call *call,
        }
 }
 
+static void update_event_fields(struct trace_event_call *call,
+                               struct trace_eval_map *map)
+{
+       struct ftrace_event_field *field;
+       struct list_head *head;
+       char *ptr;
+       int len = strlen(map->eval_string);
+
+       head = trace_get_fields(call);
+       list_for_each_entry(field, head, link) {
+               ptr = strchr(field->type, '[');
+               if (!ptr)
+                       continue;
+               ptr++;
+
+               if (!isalpha(*ptr) && *ptr != '_')
+                       continue;
+
+               if (strncmp(map->eval_string, ptr, len) != 0)
+                       continue;
+
+               ptr = eval_replace(ptr, map, len);
+               /* enum/sizeof string smaller than value */
+               WARN_ON_ONCE(!ptr);
+       }
+}
+
 void trace_event_eval_update(struct trace_eval_map **map, int len)
 {
        struct trace_event_call *call, *p;
@@ -2668,6 +2695,7 @@ void trace_event_eval_update(struct trace_eval_map **map, int len)
                                        first = false;
                                }
                                update_event_printk(call, map[i]);
+                               update_event_fields(call, map[i]);
                        }
                }
        }