dmaengine: idxd: check return result from check_vma() in cdev
authorDave Jiang <dave.jiang@intel.com>
Tue, 25 Feb 2020 16:47:46 +0000 (09:47 -0700)
committerVinod Koul <vkoul@kernel.org>
Mon, 2 Mar 2020 07:13:49 +0000 (12:43 +0530)
The returned result from the check_vma() function in the cdev ->mmap() call
needs to be handled. Add the check and returning error.

Fixes: 42d279f9137a ("dmaengine: idxd: add char driver to expose submission portal to userland")
Reported-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/158264926659.9387.14325163515683047959.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idxd/cdev.c

index 8dfdbe3..8f323e7 100644 (file)
@@ -137,6 +137,8 @@ static int idxd_cdev_mmap(struct file *filp, struct vm_area_struct *vma)
 
        dev_dbg(&pdev->dev, "%s called\n", __func__);
        rc = check_vma(wq, vma, __func__);
+       if (rc < 0)
+               return rc;
 
        vma->vm_flags |= VM_DONTCOPY;
        pfn = (base + idxd_get_wq_portal_full_offset(wq->id,