serial: omap: Remove __init marking from early write
authorJeffy Chen <jeffy.chen@rock-chips.com>
Tue, 18 Jul 2017 06:02:55 +0000 (14:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 30 Jul 2017 14:38:50 +0000 (07:38 -0700)
The earlycon would be alive outside the init code in these cases:
1/ we have keep_bootcon in cmdline.
2/ we don't have a real console to switch to.

So remove the __init marking to avoid invalid memory access.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/omap-serial.c

index 1ea05ac..7754053 100644 (file)
@@ -1235,21 +1235,20 @@ out:
 #ifdef CONFIG_SERIAL_OMAP_CONSOLE
 
 #ifdef CONFIG_SERIAL_EARLYCON
-static unsigned int __init omap_serial_early_in(struct uart_port *port,
-                                               int offset)
+static unsigned int omap_serial_early_in(struct uart_port *port, int offset)
 {
        offset <<= port->regshift;
        return readw(port->membase + offset);
 }
 
-static void __init omap_serial_early_out(struct uart_port *port, int offset,
-                                        int value)
+static void omap_serial_early_out(struct uart_port *port, int offset,
+                                 int value)
 {
        offset <<= port->regshift;
        writew(value, port->membase + offset);
 }
 
-static void __init omap_serial_early_putc(struct uart_port *port, int c)
+static void omap_serial_early_putc(struct uart_port *port, int c)
 {
        unsigned int status;
 
@@ -1262,8 +1261,8 @@ static void __init omap_serial_early_putc(struct uart_port *port, int c)
        omap_serial_early_out(port, UART_TX, c);
 }
 
-static void __init early_omap_serial_write(struct console *console,
-                                          const char *s, unsigned int count)
+static void early_omap_serial_write(struct console *console, const char *s,
+                                   unsigned int count)
 {
        struct earlycon_device *device = console->data;
        struct uart_port *port = &device->port;