drivers: mmc: Change datatype of tuning_loop_counter to int
authorAlgapally Santosh Sagar <santoshsagar.algapally@amd.com>
Fri, 20 Jan 2023 05:36:17 +0000 (22:36 -0700)
committerMichal Simek <michal.simek@amd.com>
Fri, 27 Jan 2023 07:42:47 +0000 (08:42 +0100)
tuning_loop_counter is of char type, which is not capable of handling
the entire data range of this variable. This is pointed by below sparse
warning. Change datatype to int to fix this.
warning: comparison is always false due to limited range of data type.

Signed-off-by: Algapally Santosh Sagar <santoshsagar.algapally@amd.com>
Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@amd.com>
Link: https://lore.kernel.org/r/20230120053617.32463-5-ashok.reddy.soma@amd.com
Signed-off-by: Michal Simek <michal.simek@amd.com>
drivers/mmc/zynq_sdhci.c

index 7dcf6ad..be4075c 100644 (file)
@@ -249,7 +249,7 @@ static int arasan_sdhci_execute_tuning(struct mmc *mmc, u8 opcode)
        u32 ctrl;
        struct sdhci_host *host;
        struct arasan_sdhci_priv *priv = dev_get_priv(mmc->dev);
-       char tuning_loop_counter = SDHCI_TUNING_LOOP_COUNT;
+       int tuning_loop_counter = SDHCI_TUNING_LOOP_COUNT;
 
        dev_dbg(mmc->dev, "%s\n", __func__);