Fix crash caused by Protocol::RegisterProtocol.
authorCheng Zhao <zcbenz@gmail.com>
Thu, 27 Feb 2014 02:44:45 +0000 (10:44 +0800)
committerCheng Zhao <zcbenz@gmail.com>
Thu, 27 Feb 2014 02:44:45 +0000 (10:44 +0800)
From crash report this exists on OS X too, previously the fix is only
available on Linux. However we should remove all calls of protocol
things in UI thread in future.

browser/api/atom_api_protocol.cc

index 1499f38cff7f065e371dcd757328fb55a6929160..7c44f81d4fb3c7a504e88904b1228334c9aa9dae 100644 (file)
@@ -368,11 +368,9 @@ void Protocol::Initialize(v8::Handle<v8::Object> target) {
   // Remember the protocol object, used for emitting event later.
   g_protocol_object.reset(target);
 
-#if defined(OS_LINUX)
   // Make sure the job factory has been created.
   AtomBrowserContext::Get()->url_request_context_getter()->
       GetURLRequestContext();
-#endif
 
   NODE_SET_METHOD(target, "registerProtocol", RegisterProtocol);
   NODE_SET_METHOD(target, "unregisterProtocol", UnregisterProtocol);