media: hdpvr: fix compiler warning
authorHans Verkuil <hans.verkuil@cisco.com>
Mon, 14 May 2018 12:57:03 +0000 (08:57 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 25 May 2018 19:31:23 +0000 (15:31 -0400)
In function 'strncpy',
    inlined from 'vidioc_g_audio' at media-git/drivers/media/usb/hdpvr/hdpvr-video.c:876:2:
media-git/include/linux/string.h:246:9: warning: '__builtin_strncpy' specified bound 32 equals destination size [-Wstringop-truncation]
  return __builtin_strncpy(p, q, size);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/usb/hdpvr/hdpvr-video.c

index 77c3d33..1b89c77 100644 (file)
@@ -873,7 +873,7 @@ static int vidioc_g_audio(struct file *file, void *private_data,
 
        audio->index = dev->options.audio_input;
        audio->capability = V4L2_AUDCAP_STEREO;
-       strncpy(audio->name, audio_iname[audio->index], sizeof(audio->name));
+       strlcpy(audio->name, audio_iname[audio->index], sizeof(audio->name));
        audio->name[sizeof(audio->name) - 1] = '\0';
        return 0;
 }