staging: r8188eu: bRDGEnable is always false
authorMichael Straube <straube.linux@gmail.com>
Sat, 1 Jan 2022 08:49:31 +0000 (09:49 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Jan 2022 13:30:36 +0000 (14:30 +0100)
The field bRDGEnable in struct hal_data_8188e is never set. It stays
at its default value 0. Remove bRDGEnable and related dead code.

Acked-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20220101084937.3411-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/usb_halinit.c
drivers/staging/r8188eu/include/rtl8188e_hal.h

index d5c7e8b..104705e 100644 (file)
@@ -384,13 +384,6 @@ static void _InitEDCA(struct adapter *Adapter)
        rtw_write32(Adapter, REG_EDCA_VO_PARAM, 0x002FA226);
 }
 
-static void _InitRDGSetting(struct adapter *Adapter)
-{
-       rtw_write8(Adapter, REG_RD_CTRL, 0xFF);
-       rtw_write16(Adapter, REG_RD_NAV_NXT, 0x200);
-       rtw_write8(Adapter, REG_RD_RESP_PKT_TH, 0x05);
-}
-
 static void _InitRetryFunction(struct adapter *Adapter)
 {
        u8 value8;
@@ -712,9 +705,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
        value16 |= (MACTXEN | MACRXEN);
        rtw_write8(Adapter, REG_CR, value16);
 
-       if (haldata->bRDGEnable)
-               _InitRDGSetting(Adapter);
-
        /* Enable TX Report */
        /* Enable Tx Report Timer */
        value8 = rtw_read8(Adapter, REG_TX_RPT_CTRL);
index b42af86..e8cb093 100644 (file)
@@ -236,9 +236,6 @@ struct hal_data_8188e {
 
        u32     RfRegChnlVal[2];
 
-       /* RDG enable */
-       bool     bRDGEnable;
-
        /* for host message to fw */
        u8      LastHMEBoxNum;