void RenamerClangTidyCheck::addUsage(const NamedDecl *Decl, SourceRange Range,
const SourceManager *SourceMgr) {
+ // Don't keep track for non-identifier names.
+ auto *II = Decl->getIdentifier();
+ if (!II)
+ return;
if (const auto *Method = dyn_cast<CXXMethodDecl>(Decl)) {
if (const CXXMethodDecl *Overridden = getOverrideMethod(Method))
Decl = Overridden;
}
Decl = cast<NamedDecl>(Decl->getCanonicalDecl());
- return addUsage(RenamerClangTidyCheck::NamingCheckId(Decl->getLocation(),
- Decl->getName()),
- Range, SourceMgr);
+ return addUsage(
+ RenamerClangTidyCheck::NamingCheckId(Decl->getLocation(), II->getName()),
+ Range, SourceMgr);
}
void RenamerClangTidyCheck::checkNamedDecl(const NamedDecl *Decl,
// This used to cause a null pointer dereference.
auto [left] = right;
// CHECK-MESSAGES: :[[@LINE-1]]:15: error: use of undeclared identifier 'right'
+
+namespace crash_on_nonidentifiers {
+struct Foo {
+ operator bool();
+};
+void foo() {
+ // Make sure we don't crash on non-identifier names (e.g. conversion
+ // operators).
+ if (Foo()) {}
+}
+}