http://trac.webkit.org/changeset/117095
https://bugs.webkit.org/show_bug.cgi?id=86511
broke Qt Mac build (Requested by estes on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-15
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
* Shared/Plugins/Netscape/NetscapePluginModule.h:
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
* Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::getPluginInfo):
* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
* WebProcess/Plugins/Netscape/JSNPMethod.h:
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
* WebProcess/Plugins/Netscape/JSNPObject.h:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
* WebProcess/Plugins/Netscape/NPJSObject.h:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
* WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:
* WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
* WebProcess/Plugins/Netscape/NetscapePluginStream.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
* WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h:
* WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
* WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp:
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2012-05-15 Sheriff Bot <webkit.review.bot@gmail.com>
+
+ Unreviewed, rolling out r117095.
+ http://trac.webkit.org/changeset/117095
+ https://bugs.webkit.org/show_bug.cgi?id=86511
+
+ broke Qt Mac build (Requested by estes on #webkit).
+
+ * Shared/Plugins/Netscape/NetscapePluginModule.cpp:
+ * Shared/Plugins/Netscape/NetscapePluginModule.h:
+ * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
+ * Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
+ * Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
+ * UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
+ (WebKit::PluginInfoStore::getPluginInfo):
+ * WebProcess/Plugins/Netscape/JSNPMethod.cpp:
+ * WebProcess/Plugins/Netscape/JSNPMethod.h:
+ * WebProcess/Plugins/Netscape/JSNPObject.cpp:
+ * WebProcess/Plugins/Netscape/JSNPObject.h:
+ * WebProcess/Plugins/Netscape/NPJSObject.cpp:
+ * WebProcess/Plugins/Netscape/NPJSObject.h:
+ * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
+ * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
+ * WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
+ * WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
+ * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
+ * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:
+ * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+ * WebProcess/Plugins/Netscape/NetscapePlugin.h:
+ * WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:
+ * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
+ * WebProcess/Plugins/Netscape/NetscapePluginStream.h:
+ * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
+ * WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h:
+ * WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
+ * WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp:
+ * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
+ * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
+
2012-05-15 Alexey Proskuryakov <ap@apple.com>
[WK2] Crash when dropping a reference to a non-existing file
#include "config.h"
#include "NetscapePluginModule.h"
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include "Module.h"
#include "NPRuntimeUtilities.h"
#include "NetscapeBrowserFuncs.h"
} // namespace WebKit
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
#ifndef NetscapePluginModule_h
#define NetscapePluginModule_h
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include "Module.h"
#include "PluginModuleInfo.h"
#include "PluginQuirks.h"
} // namespace WebKit
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
-
#endif // NetscapePluginModule_h
#import "config.h"
#import "NetscapePluginModule.h"
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#import "PluginProcessProxy.h"
#import <WebCore/WebCoreNSStringExtras.h>
#import <wtf/HashSet.h>
}
} // namespace WebKit
-
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
#include "config.h"
#include "NetscapePluginModule.h"
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include <WebCore/FileSystem.h>
#include <wtf/OwnArrayPtr.h>
} // namespace WebKit
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
*/
#include "config.h"
-#if PLUGIN_ARCHITECTURE(X11) && ENABLE(NETSCAPE_PLUGIN_API)
+#if PLUGIN_ARCHITECTURE(X11)
#include "NetscapePluginModule.h"
} // namespace WebKit
-#endif // PLUGIN_ARCHITECTURE(X11) && ENABLE(NETSCAPE_PLUGIN_API)
+#endif // PLUGIN_ARCHITECTURE(X11)
#import "config.h"
#import "PluginInfoStore.h"
+#import "NetscapePluginModule.h"
#import "WebKitSystemInterface.h"
#import <WebCore/WebCoreNSStringExtras.h>
#import <wtf/HashSet.h>
#import <wtf/RetainPtr.h>
-#if ENABLE(NETSCAPE_PLUGIN_API)
-#import "NetscapePluginModule.h"
-#endif
-
using namespace WebCore;
namespace WebKit {
bool PluginInfoStore::getPluginInfo(const String& pluginPath, PluginModuleInfo& plugin)
{
-#if ENABLE(NETSCAPE_PLUGIN_API)
return NetscapePluginModule::getPluginInfo(pluginPath, plugin);
-#else
- UNUSED_PARAM(pluginPath);
- UNUSED_PARAM(plugin);
- return false;
-#endif
}
bool PluginInfoStore::shouldUsePlugin(Vector<PluginModuleInfo>& alreadyLoadedPlugins, const PluginModuleInfo& plugin)
#include "config.h"
#include "JSNPMethod.h"
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include "JSNPObject.h"
#include <JavaScriptCore/Error.h>
#include <JavaScriptCore/FunctionPrototype.h>
}
} // namespace WebKit
-
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
#ifndef JSNPMethod_h
#define JSNPMethod_h
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include <JavaScriptCore/FunctionPrototype.h>
#include <JavaScriptCore/InternalFunction.h>
#include <JavaScriptCore/JSGlobalObject.h>
} // namespace WebKit
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
-
#endif // JSNPMethod_h
#include "config.h"
#include "JSNPObject.h"
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include "JSNPMethod.h"
#include "NPJSObject.h"
#include "NPRuntimeObjectMap.h"
}
} // namespace WebKit
-
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
#ifndef JSNPObject_h
#define JSNPObject_h
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include <JavaScriptCore/JSGlobalObject.h>
#include <JavaScriptCore/JSObject.h>
#include <JavaScriptCore/ObjectPrototype.h>
} // namespace WebKit
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
-
#endif // JSNPObject_h
#include "config.h"
#include "NPJSObject.h"
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include "JSNPObject.h"
#include "NPRuntimeObjectMap.h"
#include "NPRuntimeUtilities.h"
}
} // namespace WebKit
-
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
#ifndef NPJSObject_h
#define NPJSObject_h
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include <JavaScriptCore/Strong.h>
#include <WebCore/npruntime_internal.h>
#include <wtf/Noncopyable.h>
} // namespace WebKit
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
-
#endif // NPJSObject_h
#include "config.h"
#include "NPRuntimeObjectMap.h"
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include "JSNPObject.h"
#include "NPJSObject.h"
#include "NPRuntimeUtilities.h"
}
} // namespace WebKit
-
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
#ifndef NPJSObjectWrapperMap_h
#define NPJSObjectWrapperMap_h
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include <WebCore/RunLoop.h>
#include <heap/Weak.h>
#include <wtf/Forward.h>
} // namespace WebKit
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
-
#endif // NPJSObjectWrapperMap_h
#include "config.h"
#include "NPRuntimeUtilities.h"
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include <wtf/text/CString.h>
namespace WebKit {
}
} // namespace WebKit
-
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
#ifndef NPRuntimeUtilities_h
#define NPRuntimeUtilities_h
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include <WebCore/npruntime_internal.h>
#include <wtf/Forward.h>
}
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
-
#endif // NPRuntimeUtilities_h
#include "config.h"
#include "NetscapeBrowserFuncs.h"
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include "NPRuntimeUtilities.h"
#include "NetscapePlugin.h"
#include "PluginController.h"
}
} // namespace WebKit
-
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
#ifndef NetscapeBrowserFuncs_h
#define NetscapeBrowserFuncs_h
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include <WebCore/npfunctions.h>
namespace WebKit {
} // namespace WebKit
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
#endif // NetscapeBrowserFuncs_h
#include "config.h"
#include "NetscapePlugin.h"
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include "NPRuntimeObjectMap.h"
#include "NPRuntimeUtilities.h"
#include "NetscapePluginStream.h"
}
} // namespace WebKit
-
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
#ifndef NetscapePlugin_h
#define NetscapePlugin_h
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include "NetscapePluginModule.h"
#include "Plugin.h"
#include <WebCore/AffineTransform.h>
} // namespace WebKit
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
-
#endif // NetscapePlugin_h
*/
#include "config.h"
-#if PLUGIN_ARCHITECTURE(UNSUPPORTED) && ENABLE(NETSCAPE_PLUGIN_API)
+#if PLUGIN_ARCHITECTURE(UNSUPPORTED)
#include "NetscapePlugin.h"
} // namespace WebKit
-#endif // PLUGIN_ARCHITECTURE(UNSUPPORTED) && ENABLE(NETSCAPE_PLUGIN_API)
+#endif // PLUGIN_ARCHITECTURE(UNSUPPORTED)
#include "config.h"
#include "NetscapePluginStream.h"
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include "NetscapePlugin.h"
#include <utility>
#include <wtf/PassOwnPtr.h>
}
} // namespace WebKit
-
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
#ifndef NetscapePluginStream_h
#define NetscapePluginStream_h
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include <WebCore/FileSystem.h>
#include <WebCore/RunLoop.h>
#include <WebCore/npruntime_internal.h>
} // namespace WebKit
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
-
#endif // NetscapePluginStream_h
#import "config.h"
#import "NetscapePlugin.h"
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#import "NetscapeBrowserFuncs.h"
#import "PluginController.h"
#import "WebEvent.h"
#endif
} // namespace WebKit
-
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
#ifndef NetscapeSandboxFunctions_h
#define NetscapeSandboxFunctions_h
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include <WebCore/npapi.h>
#ifdef __cplusplus
}
#endif
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
-
#endif
#import "config.h"
#import "PluginProxy.h"
-#if ENABLE(PLUGIN_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API)
+#if ENABLE(PLUGIN_PROCESS)
#import "PluginController.h"
#import "PluginControllerProxyMessages.h"
} // namespace WebKit
-#endif // ENABLE(PLUGIN_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API)
+#endif // ENABLE(PLUGIN_PROCESS)
#include "config.h"
#include "PluginProxy.h"
-#if ENABLE(PLUGIN_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API)
+#if ENABLE(PLUGIN_PROCESS)
#include <WebCore/NotImplemented.h>
} // namespace WebKit
-#endif // ENABLE(PLUGIN_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API)
+#endif // ENABLE(PLUGIN_PROCESS)
#include "config.h"
#include "NetscapePlugin.h"
-#if ENABLE(NETSCAPE_PLUGIN_API)
-
#include "PluginController.h"
#include "WebEvent.h"
#include "WindowGeometry.h"
}
} // namespace WebKit
-
-#endif // ENABLE(NETSCAPE_PLUGIN_API)
*/
#include "config.h"
-#if PLUGIN_ARCHITECTURE(X11) && ENABLE(NETSCAPE_PLUGIN_API)
+#if PLUGIN_ARCHITECTURE(X11)
#include "NetscapePlugin.h"
} // namespace WebKit
-#endif // PLUGIN_ARCHITECTURE(X11) && ENABLE(NETSCAPE_PLUGIN_API)
+#endif // PLUGIN_ARCHITECTURE(X11)