[MinGW] Fix --{start,end}-group.
authorRui Ueyama <ruiu@google.com>
Thu, 1 Mar 2018 20:38:38 +0000 (20:38 +0000)
committerRui Ueyama <ruiu@google.com>
Thu, 1 Mar 2018 20:38:38 +0000 (20:38 +0000)
Currently --start-group=foo is accidentally accepted by the MinGW driver.

Differential Revision: https://reviews.llvm.org/D43836

llvm-svn: 326478

lld/MinGW/Options.td
lld/test/MinGW/driver.test

index 34bf920db0cc5da836b0f9e0477b6b534db35211..4213b8e650006f19a7bfe5c9ae9d24908bd422c8 100644 (file)
@@ -51,7 +51,7 @@ def build_id: F<"build-id">;
 def disable_auto_image_base: F<"disable-auto-image-base">;
 def enable_auto_image_base: F<"enable-auto-image-base">;
 def enable_auto_import: F<"enable-auto-import">;
-def end_group: J<"end-group">;
+def end_group: F<"end-group">;
 def full_shutdown: Flag<["--"], "full-shutdown">;
 def high_entropy_va: F<"high-entropy-va">, HelpText<"Enable 64-bit ASLR">;
 def major_image_version: S<"major-image-version">;
@@ -60,7 +60,7 @@ def no_seh: F<"no-seh">;
 def nxcompat: F<"nxcompat">, HelpText<"Enable data execution prevention">;
 def pic_executable: F<"pic-executable">;
 def sysroot: J<"sysroot">, HelpText<"Sysroot">;
-def start_group: J<"start-group">;
+def start_group: F<"start-group">;
 def tsaware: F<"tsaware">, HelpText<"Create Terminal Server aware executable">;
 def v: Flag<["-"], "v">, HelpText<"Display the version number">;
 def version: F<"version">, HelpText<"Display the version number and exit">;
index 8bf70a9b24faa2e42759b50541e88b19cd2b6c03..b0b5f56576a1421c10c469d8a3d312124ecbd018 100644 (file)
@@ -124,3 +124,5 @@ ICF-NONE: -opt:noicf
 RUN: ld.lld -### -m i386pep foo.o --icf=all | FileCheck -check-prefix ICF %s
 RUN: ld.lld -### -m i386pep foo.o -icf=all | FileCheck -check-prefix ICF %s
 ICF: -opt:icf
+
+RUN: ld.lld -### -m i386pep --start-group foo.o --end-group