staging: rtl8723bs: hal: remove redundant variable n

The variable n is being assigned a value that is never read inside
an if statement block, the assignment is redundant and can be removed.
With this removed, n is only being used for a constant loop bounds
check, so replace n with that value instead and remove n completely.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20190905152227.4610-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
index 032d018..0f33010 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
@@ -502,7 +502,7 @@ exit:
  */
 void rtl8723bs_free_recv_priv(struct adapter *padapter)
 {
-       u32 i, n;
+       u32 i;
        struct recv_priv *precvpriv;
        struct recv_buf *precvbuf;
 
@@ -514,9 +514,8 @@ void rtl8723bs_free_recv_priv(struct adapter *padapter)
        /* 3 2. free all recv buffers */
        precvbuf = (struct recv_buf *)precvpriv->precv_buf;
        if (precvbuf) {
-               n = NR_RECVBUFF;
                precvpriv->free_recv_buf_queue_cnt = 0;
-               for (i = 0; i < n ; i++) {
+               for (i = 0; i < NR_RECVBUFF; i++) {
                        list_del_init(&precvbuf->list);
                        rtw_os_recvbuf_resource_free(padapter, precvbuf);
                        precvbuf++;
@@ -525,7 +524,6 @@ void rtl8723bs_free_recv_priv(struct adapter *padapter)
        }
 
        if (precvpriv->pallocated_recv_buf) {
-               n = NR_RECVBUFF * sizeof(struct recv_buf) + 4;
                kfree(precvpriv->pallocated_recv_buf);
                precvpriv->pallocated_recv_buf = NULL;
        }