ARM: OMAP2+: only WARN if a GPMC child probe function fail
authorJavier Martinez Canillas <javier.martinez@collabora.co.uk>
Wed, 17 Apr 2013 20:34:12 +0000 (22:34 +0200)
committerJon Hunter <jon-hunter@ti.com>
Tue, 30 Apr 2013 13:43:05 +0000 (08:43 -0500)
If any of the GPMC child nodes fails, this shouldn't make the
whole gpmc_probe_dt() function to fail. It is better to just
WARN and allow other devices probe function to succeed.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Signed-off-by: Jon Hunter <jon-hunter@ti.com>
arch/arm/mach-omap2/gpmc.c

index 6166847..6c4da12 100644 (file)
@@ -1533,10 +1533,9 @@ static int gpmc_probe_dt(struct platform_device *pdev)
                         of_node_cmp(child->name, "nor") == 0)
                        ret = gpmc_probe_generic_child(pdev, child);
 
-               if (ret < 0) {
+               if (WARN(ret < 0, "%s: probing gpmc child %s failed\n",
+                        __func__, child->full_name))
                        of_node_put(child);
-                       return ret;
-               }
        }
 
        return 0;