Rename `SetResultIsInternal` and `GetResultIsInternal` to `SetSuppressPersistentResult`
and `GetSuppressPersistentResult` respectively. Also rename `m_result_is_internal`.
This matches the naming in the SB API.
A separate change calls `SetSuppressPersistentResult`, where the name
`SetResultIsInternal` doesn't quite fit.
Differential Revision: https://reviews.llvm.org/D144042
uint32_t GetPoundLineLine() const { return m_pound_line_line; }
- void SetResultIsInternal(bool b) { m_result_is_internal = b; }
+ void SetSuppressPersistentResult(bool b) { m_suppress_persistent_result = b; }
- bool GetResultIsInternal() const { return m_result_is_internal; }
+ bool GetSuppressPersistentResult() const {
+ return m_suppress_persistent_result;
+ }
void SetAutoApplyFixIts(bool b) { m_auto_apply_fixits = b; }
bool m_repl = false;
bool m_generate_debug_info = false;
bool m_ansi_color_errors = false;
- bool m_result_is_internal = false;
+ bool m_suppress_persistent_result = false;
bool m_auto_apply_fixits = true;
uint64_t m_retries_with_fixits = 1;
/// True if the executed code should be treated as utility code that is only
bool SBExpressionOptions::GetSuppressPersistentResult() {
LLDB_INSTRUMENT_VA(this);
- return m_opaque_up->GetResultIsInternal();
+ return m_opaque_up->GetSuppressPersistentResult();
}
void SBExpressionOptions::SetSuppressPersistentResult(bool b) {
LLDB_INSTRUMENT_VA(this, b);
- return m_opaque_up->SetResultIsInternal(b);
+ return m_opaque_up->SetSuppressPersistentResult(b);
}
const char *SBExpressionOptions::GetPrefix() const {
options.SetUnwindOnError(true);
options.SetIgnoreBreakpoints(true);
options.SetTryAllThreads(true);
- options.SetResultIsInternal(
+ options.SetSuppressPersistentResult(
true); // Don't generate a user variable for condition expressions.
Status expr_error;
lldb::ExpressionResults expr_result = DoExecute(
diagnostic_manager, exe_ctx, options, shared_ptr_to_me, result_var);
Target *target = exe_ctx.GetTargetPtr();
- if (options.GetResultIsInternal() && result_var && target) {
+ if (options.GetSuppressPersistentResult() && result_var && target) {
if (auto *persistent_state =
target->GetPersistentExpressionStateForLanguage(m_language))
persistent_state->RemovePersistentVariable(result_var);