Fixed coverity issues. submit/tizen/20190829.070918
authorsaerome.kim <saerome.kim@samsung.com>
Thu, 29 Aug 2019 06:37:56 +0000 (15:37 +0900)
committersaerome.kim <saerome.kim@samsung.com>
Thu, 29 Aug 2019 06:41:24 +0000 (15:41 +0900)
1076181 Resource leak.
1076152 Resource leak.

Change-Id: Ia19998552ed4822fb3ad4e01a80425c631dbd33d
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
packaging/capi-network-ua.spec
src/user-awareness-monitors.c

index 975cde6edcc40717dc2153970ad0afee17766ad7..b3112298c877cd6ef95e76de7278d2bc5de30497 100644 (file)
@@ -1,6 +1,6 @@
 Name: capi-network-ua
 Summary: User Awareness Framework CAPI
-Version: 0.6.11
+Version: 0.6.12
 Release: 1
 License: Apache-2.0
 Source0: %{name}-%{version}.tar.gz
index 8296deec4b739d6178007590779e1ebf34c7f973..aaf87eaf2f630ee7bf7025e0308bf5b96f9431c3 100644 (file)
@@ -1398,12 +1398,26 @@ int ua_monitor_start_absence_detection(
        if (monitor->service)
                if ((service && g_strcmp0(monitor->service, service)) ||
                        (!service && g_strcmp0(monitor->service, UA_SERVICE_DEFAULT))) {
+                       /* LCOV_EXCL_START */
                        g_free(service);
                        return UA_ERROR_NOT_PERMITTED;
+                       /* LCOV_EXCL_STOP */
                }
 
-       retv_if(UA_DETECT_MODE_INVALID <= mode, UA_ERROR_INVALID_PARAMETER);
-       retv_if(0 == monitor->sensor_bitmask, UA_ERROR_NO_DATA);
+       if (UA_DETECT_MODE_INVALID <= mode) {
+               /* LCOV_EXCL_START */
+               UA_ERR("Invalied mode [%d]", mode);
+               g_free(service);
+               return UA_ERROR_INVALID_PARAMETER;
+               /* LCOV_EXCL_STOP */
+       }
+       if (0 == monitor->sensor_bitmask) {
+               /* LCOV_EXCL_START */
+               UA_ERR("monitor->sensor_bitmask is 0");
+               g_free(service);
+               return UA_ERROR_NO_DATA;
+               /* LCOV_EXCL_STOP */
+       }
 
        if (!monitor->service) {
                if (service == NULL)