scsi: mpt3sas: Fix for improper info displayed in var log, while blocking or unblocki...
authorSuganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Wed, 26 Oct 2016 08:04:32 +0000 (13:34 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 8 Nov 2016 22:29:59 +0000 (17:29 -0500)
Return value and Device_handle Arguments passed in correct order
 to match with its format string.

Signed-off-by: Chaitra P B <chaitra.basappa@broadcom.com>
Signed-off-by: Sathya Prakash <sathya.prakash@broadcom.com>
Signed-off-by: Suganath Prabu S <suganath-prabu.subramani@broadcom.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_scsih.c

index 209a969..282ca40 100644 (file)
@@ -2837,7 +2837,7 @@ _scsih_internal_device_block(struct scsi_device *sdev,
        if (r == -EINVAL)
                sdev_printk(KERN_WARNING, sdev,
                    "device_block failed with return(%d) for handle(0x%04x)\n",
-                   sas_device_priv_data->sas_target->handle, r);
+                   r, sas_device_priv_data->sas_target->handle);
 }
 
 /**
@@ -2867,20 +2867,20 @@ _scsih_internal_device_unblock(struct scsi_device *sdev,
                sdev_printk(KERN_WARNING, sdev,
                    "device_unblock failed with return(%d) for handle(0x%04x) "
                    "performing a block followed by an unblock\n",
-                   sas_device_priv_data->sas_target->handle, r);
+                   r, sas_device_priv_data->sas_target->handle);
                sas_device_priv_data->block = 1;
                r = scsi_internal_device_block(sdev);
                if (r)
                        sdev_printk(KERN_WARNING, sdev, "retried device_block "
                            "failed with return(%d) for handle(0x%04x)\n",
-                           sas_device_priv_data->sas_target->handle, r);
+                           r, sas_device_priv_data->sas_target->handle);
 
                sas_device_priv_data->block = 0;
                r = scsi_internal_device_unblock(sdev, SDEV_RUNNING);
                if (r)
                        sdev_printk(KERN_WARNING, sdev, "retried device_unblock"
                            " failed with return(%d) for handle(0x%04x)\n",
-                           sas_device_priv_data->sas_target->handle, r);
+                           r, sas_device_priv_data->sas_target->handle);
        }
 }