ethernet: hisilicon: hns: hns_dsaf_mac: add missing of_node_put after calling of_pars...
authorPeter Chen <peter.chen@nxp.com>
Mon, 1 Aug 2016 07:02:34 +0000 (15:02 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 2 Aug 2016 04:43:48 +0000 (21:43 -0700)
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.

Signed-off-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c

index 3fb87e2..5c8afe1 100644 (file)
@@ -795,6 +795,7 @@ static int  hns_mac_get_info(struct hns_mac_cb *mac_cb)
                        dev_dbg(mac_cb->dev, "mac%d phy_node: %s\n",
                                mac_cb->mac_id, np->name);
                }
+               of_node_put(np);
 
                return 0;
        }
@@ -812,10 +813,12 @@ static int  hns_mac_get_info(struct hns_mac_cb *mac_cb)
                        dev_dbg(mac_cb->dev, "mac%d phy_node: %s\n",
                                mac_cb->mac_id, np->name);
                }
+               of_node_put(np);
 
-               syscon = syscon_node_to_regmap(
-                               of_parse_phandle(to_of_node(mac_cb->fw_port),
-                                                "serdes-syscon", 0));
+               np = of_parse_phandle(to_of_node(mac_cb->fw_port),
+                                       "serdes-syscon", 0);
+               syscon = syscon_node_to_regmap(np);
+               of_node_put(np);
                if (IS_ERR_OR_NULL(syscon)) {
                        dev_err(mac_cb->dev, "serdes-syscon is needed!\n");
                        return -EINVAL;