platform/x86: intel_bxtwc_tmu: Remove dev_err() usage after platform_get_irq()
authorStephen Boyd <swboyd@chromium.org>
Tue, 30 Jul 2019 18:15:54 +0000 (11:15 -0700)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 1 Aug 2019 15:03:02 +0000 (18:03 +0300)
We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.

// <smpl>
@@
expression ret;
struct platform_device *E;
@@

ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);

if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>

While we're here, remove braces on if statements that only have one
statement (manually).

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: "Darren Hart (VMware)" <dvhart@infradead.org>
Cc: Roman Kiryanov <rkir@google.com>
Cc: Vadim Pasternak <vadimp@mellanox.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/intel_bxtwc_tmu.c

index 951c105..7ccf583 100644 (file)
@@ -60,11 +60,8 @@ static int bxt_wcove_tmu_probe(struct platform_device *pdev)
        wctmu->regmap = pmic->regmap;
 
        irq = platform_get_irq(pdev, 0);
-
-       if (irq < 0) {
-               dev_err(&pdev->dev, "invalid irq %d\n", irq);
+       if (irq < 0)
                return irq;
-       }
 
        regmap_irq_chip = pmic->irq_chip_data_tmu;
        virq = regmap_irq_get_virq(regmap_irq_chip, irq);