media: friio-fe: get rid of set_property()
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Thu, 14 Sep 2017 11:44:21 +0000 (07:44 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 11 Oct 2017 16:49:55 +0000 (12:49 -0400)
This callback is not actually doing anything but making it to
return an error depending on the DTV frontend command. Well,
that could break userspace for no good reason, and, if needed,
should be implemented, instead, at set_frontend() callback.

So, get rid of it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/dvb-usb/friio-fe.c

index 0251a4e..4126131 100644 (file)
@@ -261,28 +261,6 @@ static int jdvbt90502_read_signal_strength(struct dvb_frontend *fe,
        return 0;
 }
 
-
-/* filter out un-supported properties to notify users */
-static int jdvbt90502_set_property(struct dvb_frontend *fe,
-                                  struct dtv_property *tvp)
-{
-       int r = 0;
-
-       switch (tvp->cmd) {
-       case DTV_DELIVERY_SYSTEM:
-               if (tvp->u.data != SYS_ISDBT)
-                       r = -EINVAL;
-               break;
-       case DTV_CLEAR:
-       case DTV_TUNE:
-       case DTV_FREQUENCY:
-               break;
-       default:
-               r = -EINVAL;
-       }
-       return r;
-}
-
 static int jdvbt90502_set_frontend(struct dvb_frontend *fe)
 {
        struct dtv_frontend_properties *p = &fe->dtv_property_cache;
@@ -457,8 +435,6 @@ static const struct dvb_frontend_ops jdvbt90502_ops = {
        .init = jdvbt90502_init,
        .write = _jdvbt90502_write,
 
-       .set_property = jdvbt90502_set_property,
-
        .set_frontend = jdvbt90502_set_frontend,
 
        .read_status = jdvbt90502_read_status,