subtitleoverlay: Fix caps memory leak when failing to get sinkpad from subtitle renderer
authorGarima Gaur <garima.g@samsung.com>
Mon, 28 Nov 2016 11:42:26 +0000 (17:12 +0530)
committerSebastian Dröge <sebastian@centricular.com>
Mon, 28 Nov 2016 11:56:33 +0000 (13:56 +0200)
https://bugzilla.gnome.org/show_bug.cgi?id=775224

gst/playback/gstsubtitleoverlay.c

index 65159e8d4a22a29c1ac04a139c0df4062f19cf60..c4c3cd26de759a7ebedfd497629ef238c53e28f6 100644 (file)
@@ -931,6 +931,8 @@ _link_renderer (GstSubtitleOverlay * self, GstElement * renderer,
     sink = _get_video_pad (renderer);
     if (G_UNLIKELY (!sink)) {
       GST_WARNING_OBJECT (self, "Can't get video sink from renderer");
+      if (video_caps)
+        gst_caps_unref (video_caps);
       return FALSE;
     }
     allowed_caps = gst_pad_query_caps (sink, NULL);