projects
/
platform
/
upstream
/
ofono.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
96754c0
)
gatchat: Fix compiler warning with logical expression
author
Marcel Holtmann
<marcel@holtmann.org>
Tue, 7 Jul 2015 09:28:34 +0000
(11:28 +0200)
committer
Marcel Holtmann
<marcel@holtmann.org>
Tue, 7 Jul 2015 09:35:54 +0000
(11:35 +0200)
CC gatchat/gatchat.o
gatchat/gatchat.c: In function ‘have_line’:
gatchat/gatchat.c:586:28: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
if (!strncmp(str, "AT", 2) == TRUE)
^
gatchat/gatchat.c
patch
|
blob
|
history
diff --git
a/gatchat/gatchat.c
b/gatchat/gatchat.c
index 33bfc21281b5ee22aaa09be7a9dff3eeef3ade14..d7d00605accae4751e176bc89dd87865ffb14496 100644
(file)
--- a/
gatchat/gatchat.c
+++ b/
gatchat/gatchat.c
@@
-583,7
+583,7
@@
static void have_line(struct at_chat *p, char *str)
return;
/* Check for echo, this should not happen, but lets be paranoid */
- if (!strncmp(str, "AT", 2)
== TRUE
)
+ if (!strncmp(str, "AT", 2))
goto done;
cmd = g_queue_peek_head(p->command_queue);