Drop deprecated method for backing store from AccessBuilder.
authormstarzinger@chromium.org <mstarzinger@chromium.org>
Mon, 29 Sep 2014 11:35:01 +0000 (11:35 +0000)
committermstarzinger@chromium.org <mstarzinger@chromium.org>
Mon, 29 Sep 2014 11:35:01 +0000 (11:35 +0000)
R=bmeurer@chromium.org
TEST=cctest/test-simplified-lowering/RunLoadStoreArrayBuffer

Review URL: https://codereview.chromium.org/614703002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24282 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

src/compiler/access-builder.cc
src/compiler/access-builder.h
test/cctest/compiler/test-simplified-lowering.cc

index ac9cfa858b421bbb034c5c1831439c00c320139c..749c04a0c5b1470a37e49513555fa7c44df586d2 100644 (file)
@@ -57,13 +57,6 @@ ElementAccess AccessBuilder::ForFixedArrayElement() {
 }
 
 
-// static
-ElementAccess AccessBuilder::ForBackingStoreElement(MachineType rep) {
-  return {kUntaggedBase, kNonHeapObjectHeaderSize - kHeapObjectTag, Type::Any(),
-          rep};
-}
-
-
 // static
 ElementAccess AccessBuilder::ForTypedArrayElement(ExternalArrayType type,
                                                   bool is_external) {
index 7d0bda1398e7aaec383913b1096f5a22923aab3d..72dd0234aa071eb8030145c3dcc244d0b1a59d99 100644 (file)
@@ -37,9 +37,6 @@ class AccessBuilder FINAL : public AllStatic {
   // Provides access to FixedArray elements.
   static ElementAccess ForFixedArrayElement();
 
-  // TODO(mstarzinger): Raw access only for testing, drop me.
-  static ElementAccess ForBackingStoreElement(MachineType rep);
-
   // Provides access to Fixed{type}TypedArray and External{type}Array elements.
   static ElementAccess ForTypedArrayElement(ExternalArrayType type,
                                             bool is_external);
index e67df9bfd8cabe4c7a413d31648c165371639b0a..bafa2d88f42ddc976cf9c4904c11895f612a9fa2 100644 (file)
@@ -235,7 +235,7 @@ TEST(RunLoadStoreArrayBuffer) {
   const int index = 12;
   const int array_length = 2 * index;
   ElementAccess buffer_access =
-      AccessBuilder::ForBackingStoreElement(kMachInt8);
+      AccessBuilder::ForTypedArrayElement(v8::kExternalInt8Array, true);
   Node* backing_store = t.LoadField(
       AccessBuilder::ForJSArrayBufferBackingStore(), t.Parameter(0));
   Node* load =