[Title] Refactoring to remove warning messages

[Type] BugFix
[Module]
[Priority]
[CQ#]
[Redmine#]
[Problem]
[Cause]
[Solution]
[TestCase]

diff --git a/drivers/char/vdpram.c b/drivers/char/vdpram.c
index b7968e3a52a13c43d813343c9a91211400df40fb..558f2d56d094a2efd9023e482472f28c56386b37 100755 (executable)
--- a/drivers/char/vdpram.c
+++ b/drivers/char/vdpram.c
@@ -423,9 +423,8 @@ static unsigned int vdpram_poll(struct file *filp, poll_table *wait)
 {
        struct vdpram_dev *dev = filp->private_data;
        unsigned int mask = 0;
-       int index = dev->index ;
 
-//     printk("%s:%d:index:%d\n", __FUNCTION__,current->pid,index);
+//     printk("%s:%d:index:%d\n", __FUNCTION__,current->pid,dev->index);
        /*
         * The buffer is circular; it is considered full
         * if "wp" is right behind "rp" and empty if the

diff --git a/drivers/samsung/Accelerator.c b/drivers/samsung/Accelerator.c
index 52a7bd45b8832f0ec10a57faf2e719f9ef459afb..e59d0b54fa9ff46fb9112660812a84bc3a6c419f 100644 (file)
--- a/drivers/samsung/Accelerator.c
+++ b/drivers/samsung/Accelerator.c
@@ -178,19 +178,21 @@ static int accel_open(struct inode *inode, struct file *file)
     return 0;
 }
 
-static ssize_t accel_write(struct file *file, char __user *buf, size_t count, loff_t *fops)
+static ssize_t accel_write(struct file *file, const char __user *buf, size_t count, loff_t *fops)
 {
     void __iomem *ioaddr;
 
     struct accel_param accel_param;
-    struct accel_param *test;
     unsigned long *args, *args_size;
     char *args_temp = NULL;
     int loop;
 
     ioaddr = base_addr;
 
-    copy_from_user((void *)&accel_param, (void *)buf, sizeof(struct accel_param));
+    if(copy_from_user((void *)&accel_param, (void *)buf, sizeof(struct accel_param)))
+    {
+       // error
+    }
     
     args = (unsigned long *)accel_param.args;
     args_size = (unsigned long *)accel_param.args_size;
@@ -227,9 +229,9 @@ static ssize_t accel_write(struct file *file, char __user *buf, size_t count, lo
 
     writew(accel_param.function_number, ioaddr);
     writew(accel_param.pid, ioaddr);
-    writel((uint32_t)v2p(accel_param.ret_string), ioaddr);
-    writel((uint32_t)v2p(args), ioaddr);
-    writel((uint32_t)v2p(accel_param.args_size), ioaddr);
+    writel((uint32_t)v2p((unsigned long)(accel_param.ret_string)), ioaddr);
+    writel((uint32_t)v2p((unsigned long)args), ioaddr);
+    writel((uint32_t)v2p((unsigned long)(accel_param.args_size)), ioaddr);
 
     return 0;
 }

diff --git a/drivers/samsung/emul_codec.c b/drivers/samsung/emul_codec.c
index e7d8c391859a9de6853c8cb3339e9f8663463999..9d96e898c827a82c7a7e16b16140195f25f83c8d 100644 (file)
--- a/drivers/samsung/emul_codec.c
+++ b/drivers/samsung/emul_codec.c
@@ -102,8 +102,6 @@ static struct svcodec_dev *svcodec;
 // DECLARE_WAIT_QUEUE_HEAD(waitqueue_read);
 // DECLARE_WORK(work_queue, call_workqueue);
 
-static irqreturn_t svcodec_interrupt (int irq, void *dev_id);
-
 static int svcodec_open (struct inode *inode, struct file *file)
 {
        SVCODEC_LOG("\n");
@@ -119,7 +117,7 @@ static int svcodec_open (struct inode *inode, struct file *file)
        return 0;
 }
 
-static tempCnt = 0;
+static long tempCnt = 0;
 
 static ssize_t svcodec_write (struct file *file, const char __user *buf,
                                                                size_t count, loff_t *fops)
@@ -133,7 +131,10 @@ static ssize_t svcodec_write (struct file *file, const char __user *buf,
                printk(KERN_ERR "[%s] : Fail to get codec device info\n", __func__);
        }
 
-       copy_from_user(&paramInfo, buf, sizeof(struct _param));
+       if(copy_from_user(&paramInfo, buf, sizeof(struct _param)))
+       {
+               // error handling !!!
+       }
 
        for (i = 0; i < paramInfo.in_args_num; i++) {
                writel(paramInfo.in_args[i], svcodec->ioaddr + CODEC_IN_PARAM);
@@ -225,7 +226,7 @@ static ssize_t svcodec_write (struct file *file, const char __user *buf,
                        size += sizeof(AVFrame);
                        SVCODEC_LOG("AVCODEC_ENCODE_VIDEO 1\n");
                        memcpy_toio((uint8_t*)svcodec->memaddr + size, pict_buf, pict_buf_size);
-                       SVCODEC_LOG("ENCODE Count :%d\n", ++tempCnt);
+                       SVCODEC_LOG("ENCODE Count :%ld\n", ++tempCnt);
                } else {
                        int pict_temp = 0;
                        memcpy_toio((uint8_t*)svcodec->memaddr + size, &pict_temp, sizeof(int));
@@ -339,7 +340,10 @@ static ssize_t svcodec_write (struct file *file, const char __user *buf,
                ret = (int*)paramInfo.ret;
                if (buf_size > 0) {
                        memcpy_fromio(ptr, svcodec->memaddr, buf_size);
-                       copy_to_user(paramInfo.in_args[1], ptr, buf_size);
+                       if(copy_to_user((void *)(paramInfo.in_args[1]), ptr, buf_size))
+                       {
+                               // error handling !!!
+                       }
                        memcpy_fromio(ret, (uint8_t*)svcodec->memaddr + buf_size , sizeof(int));
                } else {
                        memcpy_fromio(ret, svcodec->memaddr , sizeof(int));
@@ -353,7 +357,10 @@ static ssize_t svcodec_write (struct file *file, const char __user *buf,
                size = width * height;
                size2 = size / 4;
                memcpy_fromio(ptr, svcodec->memaddr, (size * 3 / 2));
-               copy_to_user(paramInfo.in_args[4], ptr, size + size2 * 2);
+               if(copy_to_user((void *)(paramInfo.in_args[4]), ptr, size + size2 * 2))
+               {
+                       // error handling !!!
+               }
                kfree(ptr);
        } 
 
@@ -457,6 +464,9 @@ static int svcodec_release (struct inode *inode, struct file *file)
 /*
  *  Interrupt handler
  */
+#if 0
+static irqreturn_t svcodec_interrupt (int irq, void *dev_id);
+
 static irqreturn_t svcodec_interrupt (int irq, void *dev_id)
 {
 //     SVCODEC_LOG("\n");
@@ -466,6 +476,7 @@ static irqreturn_t svcodec_interrupt (int irq, void *dev_id)
 //     return IRQ_HANDLED;
        return IRQ_NONE;
 }
+#endif
 
 struct file_operations codec_fops = {
        .owner          = THIS_MODULE,
@@ -573,7 +584,7 @@ static int __devinit svcodec_probe (struct pci_dev *pci_dev,
                printk(KERN_ERR "[%s] : ioremap failed\n", __func__);
                goto err_mem_unmap;
        }
-       SVCODEC_LOG("MEM_ADDR:0x%x, IO_ADDR:0x%x\n", svcodec->memaddr, svcodec->ioaddr);
+       SVCODEC_LOG("MEM_ADDR:0x%lx, IO_ADDR:0x%lx\n", (unsigned long)svcodec->memaddr, (unsigned long)svcodec->ioaddr);
 //     pci_set_drvdata(pci_dev, svcodec);
 
        if (register_chrdev(CODEC_MAJOR, DRIVER_NAME, &codec_fops)) {

diff --git a/drivers/samsung/emul_lcd.c b/drivers/samsung/emul_lcd.c
index b3b90b1c0726077ad96ffada1636b2a91a33086e..6adff271483ef1975ca17d2dd0455f68bc33a711 100644 (file)
--- a/drivers/samsung/emul_lcd.c
+++ b/drivers/samsung/emul_lcd.c
@@ -41,7 +41,7 @@ static int __init emul_lcd_class_init(void)
                return PTR_ERR(emul_lcd_class);
        }
 
-       emul_lcd_dev = device_create(emul_lcd_class, NULL, NULL, NULL, "emulator");
+       emul_lcd_dev = device_create(emul_lcd_class, NULL, 0, NULL, "emulator");
 
        for (i=0; i < ARRAY_SIZE(emul_lcd_device_attrib); i++) {
                ret = device_create_file(emul_lcd_dev, emul_lcd_device_attrib[i]);

diff --git a/drivers/video/backlight/emul_backlight.c b/drivers/video/backlight/emul_backlight.c
index 12abd0d374cf1e1398e9f43ad5e5012b4c3c21bd..4b58bfb12f58f2bc2d0e9d2b04a6893e7eb05cb0 100644 (file)
--- a/drivers/video/backlight/emul_backlight.c
+++ b/drivers/video/backlight/emul_backlight.c
@@ -92,11 +92,13 @@ static ssize_t bl_max_brightness_show(struct device *dev,
        return sprintf(buf, "%d\n", max_brightness);
 }
 
+#if 0
 static ssize_t bl_max_brightness_store(struct device *dev,
                struct device_attribute *attr, const char *buf, size_t count)
 {
        return 0;
 }
+#endif
 
 static DEVICE_ATTR(brightness, 0664, bl_brightness_show, bl_brightness_store);
 static DEVICE_ATTR(max_brightness, 0664, bl_max_brightness_show, NULL);
@@ -206,7 +208,7 @@ static int __init emul_backlight_class_init(void)
                return PTR_ERR(emul_backlight_class);
        }
 
-       emul_backlight_dev = device_create(emul_backlight_class, NULL, NULL, NULL, "emulator");
+       emul_backlight_dev = device_create(emul_backlight_class, NULL, 0, NULL, "emulator");
 
        for (i=0; i < ARRAY_SIZE(emul_bl_device_attrib); i++) {
                ret = device_create_file(emul_backlight_dev, emul_bl_device_attrib[i]);