Don't crash on relative redirect when original urlpath was NULL
authorDavid Woodhouse <David.Woodhouse@intel.com>
Fri, 3 Sep 2010 16:47:32 +0000 (17:47 +0100)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Fri, 3 Sep 2010 16:47:32 +0000 (17:47 +0100)
Red Hat bug #629979

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
http.c

diff --git a/http.c b/http.c
index ef8a04d..9d3abb9 100644 (file)
--- a/http.c
+++ b/http.c
@@ -709,7 +709,9 @@ int openconnect_obtain_cookie(struct openconnect_info *vpninfo)
                        vpninfo->redirect_url = NULL;
                        goto retry;
                } else {
-                       char *lastslash = strrchr(vpninfo->urlpath, '/');
+                       char *lastslash = NULL;
+                       if (vpninfo->urlpath)
+                               lastslash = strrchr(vpninfo->urlpath, '/');
                        if (!lastslash) {
                                free(vpninfo->urlpath);
                                vpninfo->urlpath = vpninfo->redirect_url;