gst/flv/gstflvparse.c: Don't strdup (and thus leak) codec name strings when passing...

Original commit message from CVS:
* gst/flv/gstflvparse.c: (gst_flv_parse_tag_audio),
(gst_flv_parse_tag_video):
Don't strdup (and thus leak) codec name strings when passing
them to gst_tag_list_add().

diff --git a/ChangeLog b/ChangeLog
index f4787d9..28cce11 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2007-12-11  Tim-Philipp Müller  <tim at centricular dot net>
+
+       * gst/flv/gstflvparse.c: (gst_flv_parse_tag_audio),
+         (gst_flv_parse_tag_video):
+         Don't strdup (and thus leak) codec name strings when passing
+         them to gst_tag_list_add().
+
 2007-12-10  Wim Taymans  <wim.taymans@collabora.co.uk>
 
        * gst/rtpmanager/gstrtpbin.c: (gst_rtp_bin_class_init),

diff --git a/gst/flv/gstflvparse.c b/gst/flv/gstflvparse.c
index f795466..a29e873 100644 (file)
--- a/gst/flv/gstflvparse.c
+++ b/gst/flv/gstflvparse.c
@@ -494,7 +494,7 @@ gst_flv_parse_tag_audio (GstFLVDemux * demux, const guint8 * data,
       if (demux->taglist == NULL)
         demux->taglist = gst_tag_list_new ();
       gst_tag_list_add (demux->taglist, GST_TAG_MERGE_REPLACE,
-          GST_TAG_AUDIO_CODEC, g_strdup (codec_name), NULL);
+          GST_TAG_AUDIO_CODEC, codec_name, NULL);
     }
 
     GST_DEBUG_OBJECT (demux, "created audio pad with caps %" GST_PTR_FORMAT,
@@ -577,7 +577,7 @@ gst_flv_parse_tag_audio (GstFLVDemux * demux, const guint8 * data,
       if (demux->taglist == NULL)
         demux->taglist = gst_tag_list_new ();
       gst_tag_list_add (demux->taglist, GST_TAG_MERGE_REPLACE,
-          GST_TAG_AUDIO_CODEC, g_strdup (codec_name), NULL);
+          GST_TAG_AUDIO_CODEC, codec_name, NULL);
     }
 
     gst_caps_unref (caps);
@@ -767,7 +767,7 @@ gst_flv_parse_tag_video (GstFLVDemux * demux, const guint8 * data,
       if (demux->taglist == NULL)
         demux->taglist = gst_tag_list_new ();
       gst_tag_list_add (demux->taglist, GST_TAG_MERGE_REPLACE,
-          GST_TAG_VIDEO_CODEC, g_strdup (codec_name), NULL);
+          GST_TAG_VIDEO_CODEC, codec_name, NULL);
     }
 
     /* Store the caps we have set */
@@ -839,7 +839,7 @@ gst_flv_parse_tag_video (GstFLVDemux * demux, const guint8 * data,
       if (demux->taglist == NULL)
         demux->taglist = gst_tag_list_new ();
       gst_tag_list_add (demux->taglist, GST_TAG_MERGE_REPLACE,
-          GST_TAG_VIDEO_CODEC, g_strdup (codec_name), NULL);
+          GST_TAG_VIDEO_CODEC, codec_name, NULL);
     }
 
     /* Store the caps we have set */