video: fbdev: clcdfb: Fix refcount leak in clcdfb_of_vram_setup

of_parse_phandle() returns a node pointer with refcount incremented, we should
use of_node_put() on it when not need anymore.  Add missing of_node_put() to
avoid refcount leak.

Fixes: d10715be03bd ("video: ARM CLCD: Add DT support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
index 9ec969e..8080116 100644 (file)
--- a/drivers/video/fbdev/amba-clcd.c
+++ b/drivers/video/fbdev/amba-clcd.c
@@ -758,12 +758,15 @@ static int clcdfb_of_vram_setup(struct clcd_fb *fb)
                return -ENODEV;
 
        fb->fb.screen_base = of_iomap(memory, 0);
-       if (!fb->fb.screen_base)
+       if (!fb->fb.screen_base) {
+               of_node_put(memory);
                return -ENOMEM;
+       }
 
        fb->fb.fix.smem_start = of_translate_address(memory,
                        of_get_address(memory, 0, &size, NULL));
        fb->fb.fix.smem_len = size;
+       of_node_put(memory);
 
        return 0;
 }