Input: sensehat-joystick - remove unnecessary error message
authorYang Li <yang.lee@linux.alibaba.com>
Wed, 29 Jun 2022 05:49:08 +0000 (22:49 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 29 Jun 2022 05:50:48 +0000 (22:50 -0700)
The print function dev_err() is redundant because platform_get_irq()
already prints an error.

Eliminates the follow coccicheck warning:

./drivers/input/joystick/sensehat-joystick.c:102:2-9: line 102 is redundant because platform_get_irq() already prints an error

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/20220427004906.129893-1-yang.lee@linux.alibaba.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/joystick/sensehat-joystick.c

index 5ad1fe4ff496a3afb824fcf1f9706306dda01f9e..a84df39d3b2fa6e3d88ba9671cfb693ae3b2d85d 100644 (file)
@@ -98,10 +98,8 @@ static int sensehat_joystick_probe(struct platform_device *pdev)
        }
 
        irq = platform_get_irq(pdev, 0);
-       if (irq < 0) {
-               dev_err(&pdev->dev, "Could not retrieve interrupt request");
+       if (irq < 0)
                return irq;
-       }
 
        error = devm_request_threaded_irq(&pdev->dev, irq,
                                          NULL, sensehat_joystick_report,