tools/bootconfig: fix single & used for logical condition
authorAntonio Alvarez Feijoo <antonio.feijoo@suse.com>
Tue, 21 Feb 2023 23:27:35 +0000 (08:27 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:34:27 +0000 (09:34 +0100)
commit cf8c59a3756b2735c409a9b3ac1e4ec556546a7a upstream.

A single & will create a background process and return true, so the grep
command will run even if the file checked in the first condition does not
exist.

Link: https://lore.kernel.org/all/20230112114215.17103-1-antonio.feijoo@suse.com/
Fixes: 1eaad3ac3f39 ("tools/bootconfig: Use per-group/all enable option in ftrace2bconf script")
Signed-off-by: Antonio Alvarez Feijoo <antonio.feijoo@suse.com>
Cc: stable@vger.kernel.org
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/bootconfig/scripts/ftrace2bconf.sh

index 6183b36..1603801 100755 (executable)
@@ -93,7 +93,7 @@ referred_vars() {
 }
 
 event_is_enabled() { # enable-file
-       test -f $1 & grep -q "1" $1
+       test -f $1 && grep -q "1" $1
 }
 
 per_event_options() { # event-dir